Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is expansions list up-to-date at npmjs.com? #881

Closed
gregdeane opened this issue Dec 28, 2015 · 5 comments
Closed

Is expansions list up-to-date at npmjs.com? #881

gregdeane opened this issue Dec 28, 2015 · 5 comments

Comments

@gregdeane
Copy link
Contributor

It doesn't seem like many of the recent expansions are live at npmjs.com. Not sure if this is purposeful, a caching issue, or I'm just being dumb.

On the live site, this file appears to contain the expansions: https://www.npmjs.com/static/js/index.min.6833b586.js.

However, those expansions do not match the latest expansions.txt file.

@jbruni
Copy link

jbruni commented Dec 31, 2015

I don't know and I'm not sure, but I guess the live site has latest version, which is 2.2.3: https://github.com/npm/npm-expansions/tree/v2.2.3

I think these latest/most-recent additions to expansions.txt will go live/production when the next version is released (v2.2.4 ?)

@gregdeane
Copy link
Contributor Author

I don't think v2.2.3 is live. Search "Nashville Plays Music" on the following files:

https://github.com/npm/npm-expansions/blob/v2.2.3/expansions.txt (search term found)
https://www.npmjs.com/static/js/index.min.6833b586.js (search term not found)

Again, might be a caching issue or a mistake on my part.

@jbruni
Copy link

jbruni commented Jan 1, 2016

Hmmm... indeed.

Look what I've found: https://github.com/npm/newww/commit/19f1feb631092afd0abe96d2e9ef41334384ac2e

@jonathanmarvens
Copy link

Just merged npm/newww#1703, so I'm closing this. Thanks, y'all 😄.

@gregdeane
Copy link
Contributor Author

@jonathanmarvens thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants