Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] npm pack should not attempt to include unix socket files #54

Closed
coreyfarrell opened this issue May 8, 2020 · 0 comments · Fixed by #88
Closed

[BUG] npm pack should not attempt to include unix socket files #54

coreyfarrell opened this issue May 8, 2020 · 0 comments · Fixed by #88

Comments

@coreyfarrell
Copy link

How

See https://github.com/coreyfarrell/pack-socket for demonstration

Current Behavior

If a unix socket file has a filename that would be included in npm pack it is not ignored. This causes a cb() never called! error.

Steps to Reproduce

On Linux (or maybe OSX):

git clone https://github.com/coreyfarrell/pack-socket
cd pack-socket
npm pack

Expected Behavior

Unix socket files should be ignored regardless of .npmignore / package.json#files settings

@nlf nlf closed this as completed in #88 Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant