This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
doc: Update URLs to https used in defaults.js #10570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the default registry URLs in the docs in: * doc/misc/npm-registry.md * doc/cli/npm-adduser.md * doc/cli/npm-logout.md from: http://registry.npmjs.org/ to: https://registry.npmjs.org/ to make it consistent with the actual value in lib/config/defaults.js Also changed several GitHub and npm.js links to https (the http links get redirected to https anyway but it's better to avoid insecure redirection) and Stack Overflow and OSI links (those don't get redirected so it's even more important for them to use secure URLs) in: * doc/cli/npm.md * doc/files/package.json.md * doc/misc/npm-developers.md * doc/misc/npm-faq.md
othiym23
pushed a commit
that referenced
this pull request
Dec 11, 2015
Changed the default registry URLs in the docs in:
* doc/misc/npm-registry.md
* doc/cli/npm-adduser.md
* doc/cli/npm-logout.md
from: http://registry.npmjs.org/
to: https://registry.npmjs.org/
to make it consistent with the actual value in lib/config/defaults.js.
Also changed several GitHub and npm.js links to https (the HTTP links
get redirected to HTTPS anyway but it's better to avoid insecure
redirection) and Stack Overflow and OSI links (those don't get
redirected so it's even more important for them to use secure URLs) in:
* doc/cli/npm.md
* doc/files/package.json.md
* doc/misc/npm-developers.md
* doc/misc/npm-faq.md
Credit: @rsp
Reviewed-By: @othiym23
PR-URL: #10570
|
Reformatted the commit message a little bit and landed for |
othiym23
pushed a commit
that referenced
this pull request
Dec 11, 2015
Changed the default registry URLs in the docs in:
* doc/misc/npm-registry.md
* doc/cli/npm-adduser.md
* doc/cli/npm-logout.md
from: http://registry.npmjs.org/
to: https://registry.npmjs.org/
to make it consistent with the actual value in lib/config/defaults.js.
Also changed several GitHub and npm.js links to https (the HTTP links
get redirected to HTTPS anyway but it's better to avoid insecure
redirection) and Stack Overflow and OSI links (those don't get
redirected so it's even more important for them to use secure URLs) in:
* doc/cli/npm.md
* doc/files/package.json.md
* doc/misc/npm-developers.md
* doc/misc/npm-faq.md
Credit: @rsp
Reviewed-By: @othiym23
PR-URL: #10570
|
Cherry-picked for |
|
@othiym23 Thanks. My pleasure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the default registry URLs in the docs from http://registry.npmjs.org/ to https://registry.npmjs.org/ to make it consistent with the actual value in lib/config/defaults.js in:
Also changed several GitHub and npm.js links to https (the http links get redirected to https anyway
but it's better to avoid insecure redirection) and Stack Overflow and OSI links (those don't get redirected so it's even more important for them to use secure URLs) in: