Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

save: stop using url.format for relative local dep paths #15114

Closed
wants to merge 2 commits into from
Closed

save: stop using url.format for relative local dep paths #15114

wants to merge 2 commits into from

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Dec 2, 2016 •
edited

node@7 introduced an issue with file URIs that broke the way npm was expecting them to be parsed. Turns out we don't really need to be doing any parsing in this particular case. I've added tests to verify things, too.

Fixes: #15097

@zkat zkat added this to the next milestone Dec 2, 2016
@zkat zkat mentioned this pull request Dec 2, 2016
Closed
4 tasks
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 85.682% when pulling 589bc27 on zkat/file-urls into 4d0473c on release-next.

iarna pushed a commit that referenced this pull request Dec 14, 2016
@zkat @iarna
save: stop using url.format for relative local dep paths
173935b 
Fixes: #15097
PR-URL: #15114
Credit: @zkat
Reviewed-By: @iarna
@iarna iarna force-pushed the release-next branch 7 times, most recently from 20e7365 to ff1f0bb Compare December 16, 2016 01:53
@iarna
Copy link
Contributor

iarna commented Dec 16, 2016

This was merged and released in 4.1.0.

@iarna iarna closed this Dec 16, 2016
@gustavohenke gustavohenke mentioned this pull request Jan 24, 2017
Closed
@zkat zkat mentioned this pull request Jan 26, 2017
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iarna iarna iarna approved these changes

Assignees
No one assigned
Labels
review target-latest
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zkat @coveralls @iarna