Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Allow versioning for github repos as dependencies #3014

Closed
MatthewMueller opened this Issue · 15 comments

5 participants

Matthew Mueller Nathan Zadoks Roman Shtylman Domenic Denicola Luke Arduini
Matthew Mueller

This would be a really nice feature to have:

"dependencies": {
  "set": "component/set@1.0.0"
}

or perhaps:

"dependencies": {
  "set": "component/set#1.0.0"
}
Nathan Zadoks
Collaborator

Semver for tags would be pretty awesome and certainly doable. I think we should support # for straight tags and @ for semver with tags (v1.2.3 style tags, like npm does)

Nathan Zadoks
Collaborator

I've added support for # on GitHub deps (115d67d). I'll see if we can implement semver.

Matthew Mueller

awesome man, thanks!

Roman Shtylman

See this post about git dependencies:
http://shtylman.com/post/npm-git-with-the-program/

You can already specify specific versions if you push the tags to git.

Nathan Zadoks
Collaborator

Yes, this already worked for straight git deps. This is about component-style "user/repo" deps.

Roman Shtylman

@nathan7 It works for those as well.

Nathan Zadoks
Collaborator

Whoops. My (and @MatthewMueller's) bad.

Domenic Denicola
Collaborator

So to clarify, we have exact version support, but still want semver support.

Roman Shtylman

@domenic I personally think exact versons are the way to go for various reasons (which I have outlined before).

Domenic Denicola domenic referenced this issue in requirejs/text
Closed

Publish to npm #32

Nathan Zadoks
Collaborator

Okay, with the current git approach this should be no issue. I have to figure out if I can make it work for GitHub archives too.

Domenic Denicola
Collaborator

So @isaacs decided against the remaining part of this feature in #3328. Closing.

Domenic Denicola domenic closed this
Roman Shtylman
Domenic Denicola
Collaborator

@shtylman the last part being

So to clarify, we have exact version support, but still want semver support.

Roman Shtylman
Luke Arduini

yesssss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.