Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Allow versioning for github repos as dependencies #3014

Closed
matthewmueller opened this issue Dec 21, 2012 · 15 comments
Closed

Allow versioning for github repos as dependencies #3014

matthewmueller opened this issue Dec 21, 2012 · 15 comments

Comments

@matthewmueller
Copy link

This would be a really nice feature to have:

"dependencies": {
  "set": "component/set@1.0.0"
}

or perhaps:

"dependencies": {
  "set": "component/set#1.0.0"
}
@edef1c
Copy link
Contributor

edef1c commented Dec 22, 2012

Semver for tags would be pretty awesome and certainly doable. I think we should support # for straight tags and @ for semver with tags (v1.2.3 style tags, like npm does)

@edef1c
Copy link
Contributor

edef1c commented Dec 28, 2012

I've added support for # on GitHub deps (115d67d). I'll see if we can implement semver.

@matthewmueller
Copy link
Author

awesome man, thanks!

@defunctzombie
Copy link

See this post about git dependencies:
http://shtylman.com/post/npm-git-with-the-program/

You can already specify specific versions if you push the tags to git.

@edef1c
Copy link
Contributor

edef1c commented Dec 30, 2012

Yes, this already worked for straight git deps. This is about component-style "user/repo" deps.

@defunctzombie
Copy link

@nathan7 It works for those as well.

@edef1c
Copy link
Contributor

edef1c commented Dec 31, 2012

Whoops. My (and @matthewmueller's) bad.

@domenic
Copy link
Contributor

domenic commented Jan 6, 2013

So to clarify, we have exact version support, but still want semver support.

@defunctzombie
Copy link

@domenic I personally think exact versons are the way to go for various reasons (which I have outlined before).

@edef1c
Copy link
Contributor

edef1c commented Jan 8, 2013

Okay, with the current git approach this should be no issue. I have to figure out if I can make it work for GitHub archives too.

@domenic
Copy link
Contributor

domenic commented May 15, 2013

So @isaacs decided against the remaining part of this feature in #3328. Closing.

@domenic domenic closed this as completed May 15, 2013
@defunctzombie
Copy link

The last part being the @? Cause the # one is supported if you have a tag.
On May 15, 2013 11:01 AM, "Domenic Denicola" notifications@github.com
wrote:

So @isaacs https://github.com/isaacs decided against the remaining part
of this feature in #3328 https://github.com/isaacs/npm/issues/3328.
Closing.


Reply to this email directly or view it on GitHubhttps://github.com/isaacs/npm/issues/3014#issuecomment-17944045
.

@domenic
Copy link
Contributor

domenic commented May 15, 2013

@shtylman the last part being

So to clarify, we have exact version support, but still want semver support.

@defunctzombie
Copy link

Meh. You know how I feel about semver in deps :p
On May 15, 2013 5:05 PM, "Domenic Denicola" notifications@github.com
wrote:

@shtylman https://github.com/shtylman the last part being

So to clarify, we have exact version support, but still want semver
support.


Reply to this email directly or view it on GitHubhttps://github.com/isaacs/npm/issues/3014#issuecomment-17966167
.

@luk-
Copy link
Contributor

luk- commented May 20, 2013

yesssss

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants