Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Potential bug with shrinkwrapped dependencies #3675

Closed
jmreidy opened this issue Jul 19, 2013 · 4 comments
Closed

Potential bug with shrinkwrapped dependencies #3675

jmreidy opened this issue Jul 19, 2013 · 4 comments

Comments

@jmreidy
Copy link

jmreidy commented Jul 19, 2013

Grunt has async as a dependency. The weird behavior is the following:

npm install --save-dev async@0.1.22 - async is installed as a dependency.
npm install --save grunt - grunt is installed; it does not install async as a dependency for itself (ie grunt/node_modules/async does not exist)

npm shrinkwrap then (correctly) does not include async as a dependency for grunt, since it's not in grunt's node_modules directory. But that's obviously a problem for npm install --production.

@smikes
Copy link
Contributor

smikes commented Nov 17, 2014

I confirm that I can reproduce the behavior described above with latest npm - npm@2.1.8 as of today.

This may be fixed by the upcoming multi-stage install feature, planned for npm@3

A potential workaround, mentioned in #4036, is to use

$ npm shrinkwrap --dev

@smikes
Copy link
Contributor

smikes commented Jan 6, 2015

/cc @othiym23 This should be labeled 'bug', I think

@othiym23 othiym23 added bug and removed support labels Jan 7, 2015
@othiym23
Copy link
Contributor

othiym23 commented Jan 7, 2015

So noted, but I'm also going to add this to the multi-stage install milestone (att'n @iarna) so it gets looked at soonish.

@othiym23 othiym23 added this to the multi-stage install milestone Jan 7, 2015
@iarna
Copy link
Contributor

iarna commented Apr 10, 2015

This is now fixed in the npm/npm#multi-stage branch.

@iarna iarna closed this as completed Apr 10, 2015
@npm npm locked and limited conversation to collaborators Jun 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants