This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
npm version should work in a git directory w/o git
#6528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a package seemed to be located in a git directory (for example, if it was alongside a ".git" directory), but the user did not have git on their path, npm would throw a cryptic error about calling trim on undefined. With this patch, npm will log that git was not found, and that tagging the version was skipped, but otherwise go on to updating the package.json file. This was probably primarily felt by Windows users, where git might be located within a GUI client, but would be using npm from the command prompt.
othiym23
force-pushed
the
version-handle-enogit
branch
from
777277d
to
80b368f
Compare
|
Thank you, @terinjokes! Also thank you for including a test! |
|
Changes Unknown when pulling 80b368f on version-handle-enogit into * on master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a package seemed to be located in a git directory (for example, if it
was alongside a ".git" directory), but the user did not have git on
their path, npm would throw a cryptic error about calling trim on
undefined.
With this patch, npm will log that git was not found, and that tagging
the version was skipped, but otherwise go on to updating the
package.json file.
This was probably primarily felt by Windows users, where git might be
located within a GUI client, but would be using npm from the command
prompt.