-
Notifications
You must be signed in to change notification settings - Fork 3k
npm install --save with a git dependency saves a relative path to tmp/ #7121
Comments
Thanks for the bug report! /cc @othiym23 bug report |
Confirmed. Thanks for the report! This needs both a patch and a regression test, because I'm sure my recent meddling with git caching to fix things is responsible for this, but none of the relevant tests caught it. |
Is there already an issue filed about tmp folders being put into the shrinkwrap (has been happening since npm >2.1.4): "cookieman": {
"version": "0.0.0",
"from": "../../../../../var/folders/hf/nd46_7jd41zd1g1bgymsl1rw0000gn/T/npm-31235-4b3b79e1/git-cache-2c0066f6ed57/9f1b66bdc0460c86e5d72cfe66b210422826f877",
"resolved": "git+ssh://git@github.com:cookieman/cookieman.git#9f1b66bdc0460c86e5d72cfe66b210422826f877"
} |
Ah, I can see this is related to how git deps are installed.. (the installed package.json contains incorrect "_from" which must break the shrinkwrap) |
I would be so happy to see this fixed! |
Likewise! this bit me and I forgot to report it! |
See #7296 for a fix for this, which may or may not land this week. |
Did this get fixed as part of |
@smikes I don't know / don't think so. They turned out to be fairly different issues. |
:( This issue (I think it's this issue) breaks all npm+git+shrinkwrap usage. It's preventing my team and me from upgrading to anything above npm 2.1.4. Not complaining - just letting you know ;) I'll try to take a closer look at whether this is resolved in 2.7.0 and see if I can fix it.. |
I can confirm the issue still happens in 2.7.0. Steps to reproduce
package.json contains: {
...
"dependencies": {
"pkguid": "file:../../../../../../var/folders/hf/nd46_7jd41zd1g1bgymsl1rw0000gn/T/npm-18964-1b8d06aa/git-cache-10aa7514779c/894f50939c7626c6d3d61ff33faa71155290bcf4"
}
} This also affects |
This also needs to get fixed soon to unblock shrinkwrap users, so I will look at getting this into this week's release. |
There is a fix in #7539; it got kind of messy because I realized that |
This is finally fixed in 6823807. With any luck, I a. didn't introduce any new regressions and b. have made it less likely that things will go wrong with caching git remotes in the future. Thanks to everyone for their patience. |
❤️ |
🎠 🌈 💫 |
I just ran into this issue and I upgraded to npm 2.11.0 (from 2.7.0) and it is now resolved. Just do |
Prior to NPM 2.0, this would have saved as:
It works as expected if I use the
aearly/somemodule
shorthand.The text was updated successfully, but these errors were encountered: