Skip to content
This repository has been archived by the owner on Aug 11, 2022. It is now read-only.

Coding style: Double vs single quotes #9208

Closed
ahstro opened this issue Aug 9, 2015 · 4 comments
Closed

Coding style: Double vs single quotes #9208

ahstro opened this issue Aug 9, 2015 · 4 comments

Comments

@ahstro
Copy link

ahstro commented Aug 9, 2015

Reading through and loving the your style-guidesque docs and I noticed that there was no mention of the ever raging war between double and single quotes. I skimmed through some of your code and found that single quotes seemed to be preferred a majority of the time; if this is the case, shouldn't it be reflected in your style guidelines?

@kenany
Copy link
Contributor

kenany commented Aug 9, 2015

@ahstro Yes, the coding style has changed to that of standard. That documentation can be updated with a pull request :)

@othiym23
Copy link
Contributor

npm@2 has no particular preference with respect to double versus single quotes, but as @kenany mentioned, npm@3 is checked against standard. The style guide needs to be updated to reflect that fact, but that won't show up in the docs until npm@3 is latest (i.e. moves out of beta). A patch to the docs would be most welcome!

@aaron-j-krause
Copy link
Contributor

I have a patch for this should I do the pull request against master?

@othiym23
Copy link
Contributor

Yep! npm@3 releases are branched from master, so that's the right place to make changes to its documentation!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants