Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: refactor minipass-fetch #382

Closed
nlf opened this issue Aug 23, 2021 · 1 comment
Closed

task: refactor minipass-fetch #382

nlf opened this issue Aug 23, 2021 · 1 comment

Comments

@nlf
Copy link

nlf commented Aug 23, 2021

minipass-fetch is largely ported code from node-fetch to use minipass streams. we should take a much closer look at it and attempt to clean the code up to be more maintainable, as well as keeping a careful eye out for mishandling of stream errors. there exists a single Promise constructor there that does almost all of the work in a request's lifetime and that should very much not be the case.

@nlf nlf added the Backlog label Aug 23, 2021
@settings settings bot removed the Backlog label Aug 31, 2021
@wraithgar
Copy link
Member

While not a full refactor we have fixed a good portion of the concerns here.

npm/minipass-fetch#64
npm/minipass-fetch#53

@wraithgar wraithgar closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants