Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The version of this in normalize-package-data emits a warning for conflicts with core modules #1

Closed
iarna opened this issue Nov 17, 2014 · 3 comments

Comments

@iarna
Copy link

iarna commented Nov 17, 2014

Specifically:

 if (coreModuleNames.indexOf(data.name) !== -1)
      this.warn("conflictingName", data.name)

Using this list.

I'm not saying we should warn here, but I'd like to have that discussion.

@othiym23
Copy link

We definitely want to warn on this. There are valid use cases for overriding core modules (particularly when polyfilling stuff from Node for browserify pipelines – I know @feross, among others, leans on this pretty hard), but in general, leaning on a builtin is a mistake because it will be completely ignored by Node's module loader (as mentioned elsewhere).

@feross
Copy link

feross commented Nov 21, 2014

Wrote my thoughts on this here: #2 (comment)

@zeke
Copy link
Contributor

zeke commented Apr 9, 2015

https://www.npmjs.com/package/validate-npm-package-name 2.0 landed a few months back, with support for checking against core modules.

@zeke zeke closed this as completed Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants