Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big board CSS generator should skip liveblog #195

Open
alykat opened this issue Oct 22, 2018 · 0 comments
Open

Big board CSS generator should skip liveblog #195

alykat opened this issue Oct 22, 2018 · 0 comments
Labels
bug Something isn't working effort:light An estimated 1–4 hours of work priority:low

Comments

@alykat
Copy link
Member

alykat commented Oct 22, 2018

Right now, the script (fab utils:create_board_overridecss) loops over everything in the nav sheet and generates a big board-style override for every Seamus ID in the list. That includes the liveblog. However, the liveblog uses a different template (the standard story template rather than the wide multimedia template), and its overridecss is backed up in the liveblog repo. Having the version in the election18-graphics repo means that it's easy to accidentally overwrite existing liveblog styles.

Ideally, the process that generates the board css files would be able to check that the slug isn't "liveblog" before generating the css. (It appears to only look at Seamus IDs, not any of the other columns.)

Not a big deal, but something to be aware of / look into for the next time this feature is used.

@alykat alykat added bug Something isn't working effort:light An estimated 1–4 hours of work priority:low labels Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort:light An estimated 1–4 hours of work priority:low
Projects
None yet
Development

No branches or pull requests

1 participant