Update destructuring 2.md #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm very new to Rust and the changes I proposed may either be incorrect or not fit in the flow of the document. Please feel free to suggest modifications that I can make or to reject altogether. Thanks.
nrc
reviewed
Jan 30, 2017
destructuring 2.md
Outdated
| You can also choose to have copy semantics for structs defined by you. | ||
| Use `#[derive(Copy)]` to implement the `Copy` trait and the struct would | ||
| have Copy semantics. You may also need to derive the `Clone` trait needed | ||
| by the `Copy` trait. |
There was a problem hiding this comment.
This is an improvement but it is not quite complete. So, I would say that to have copy semantics you have to implement Copy and derive is one way to do that. It is also worth noting that there restrictions on whether a type can have the Copy trait implemented - in particular, the destructor thing (see https://doc.rust-lang.org/std/marker/trait.Copy.html#when-can-my-type-be-copy for details).
Add information about destructors and their effect on allowing `Copy` trait to be implemented by the struct in question.
|
Thanks you for taking the time to comment (and of course the very wonderfully written series). I (think I) have addressed your comment and put back some destructor related content from my previous deletion. Please let me know if any more changes are required. |
nrc
reviewed
Jan 30, 2017
destructuring 2.md
Outdated
| fields are examined and if any of those do then the whole object has move | ||
| semantics. And so on down the object structure. If no destructors are found | ||
| anywhere in an object, then it has copy semantics. | ||
| You can also choose to have copy semantics for user-defined structs |
destructuring 2.md
Outdated
| anywhere in an object, then it has copy semantics. | ||
| You can also choose to have copy semantics for user-defined structs | ||
| by implementing the `Copy` trait. One straightforward way to do that is | ||
| to add `#[derive(Copy)]` before the definition of the struct. Not all |
destructuring 2.md
Outdated
| those with a destructor. Destructors probably need a post of their own, | ||
| but for now, an object in Rust has a destructor if it implements the `Drop` | ||
| trait. Just like C++, the destructor is executed just before an object is | ||
| destroyed. If an object has a destructor then it has move semantics. |
Sorry about the delay, I was going to blame github but I checked and there indeed was an email notifying me about your review. I've addressed your comments: 1) Mention that all fields of a type must implement `Copy` for that type to implement `Copy` 2) Replace the word struct with types in a few places. (I've left it at places where it was a keyword) 3) Dropped the sentence- "if an object has a destructor then it has move semantics" Feel free to let me know if there's still things that I should improve- hopefully I'll see the email in time
|
I've addressed your comments, please let me know if any other changes are required. |
|
Thanks for the changes, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm very new to Rust and the changes I proposed may either be incorrect or not fit in the flow of the document. Please feel free to suggest modifications that I can make or to reject altogether. Thanks.