Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace --tech with --breaks-style in make-maps CLI #41

Closed
mjgleason opened this issue May 31, 2023 · 1 comment
Closed

Replace --tech with --breaks-style in make-maps CLI #41

mjgleason opened this issue May 31, 2023 · 1 comment
Assignees

Comments

@mjgleason
Copy link
Collaborator

Why this feature is necessary:
Currently, the make-maps command allows the user to select from two technologies (wind and solar), which results in the use of hard-coded legend breaks for the various maps.

@ppinchuk raised the point that this is limiting for other technologies (e.g., geothermal) and, even for wind and solar, the hard-coded legend breaks may not always be suitable for every supply curve.

A possible solution is:
As discussed in PR 38, a possible solution would be to replace the existing --tech option with a --breaks-style option. The user could then choose from a set of options including wind and solar (which would use the existing hard-coded breaks for those technologies) or auto, which would use an automatic classification (e.g., Jenks-Fisher with 5 breaks).

I have considered the following alternatives:
An alternative solution would be to implement the new --breaks-style and enable the user to select any classification from https://pysal.org/mapclassify/api.html#classifiers. The user would have to specify the classifier name (and if applicable, a number of breaks), e.g., --breaks-style fisherjenks:5.

Additional context
NA

Charge code
NA. This is a nice to have at the moment.

Urgency / Timeframe
Not urgent at all.

@mjgleason
Copy link
Collaborator Author

Closed by #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant