Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] adonis-queue vs adonis-kue: Whats the difference? #1

Closed
nicklaw5 opened this issue Sep 17, 2016 · 4 comments
Closed

[Discussion] adonis-queue vs adonis-kue: Whats the difference? #1

nicklaw5 opened this issue Sep 17, 2016 · 4 comments

Comments

@nicklaw5
Copy link

nicklaw5 commented Sep 17, 2016

@nrempel I have taken a look at both your implementations of adonis-queue and adonis-kue. Can I ask why you switched to bull over kue in adonis-queue? Do you you feel one library does a better job than the other?

I have just integrated adonis-kue into my application, and at the same time extended the API. I was going to create a PR to incorporate my additions to the library and then I came across adonis-queue.

I can see that the API for adonis-queue is very similar to that of its kue counterpart. Would it be wise for me to create a PR for both libraries, since my changes can extend both packages? Or are you only going to be maintaining one of these packages?

@nrempel
Copy link
Owner

nrempel commented Sep 19, 2016

Hi @nicklaw5,

I wrote this library first, then recently ported it over to use bull. It was an experiment to see how it performed in the system that I use this library in.

My reasons for doing it were to evaluate any performance improvements over kue. Mainly, I wanted to get away from kue's use of client-side state tracking which can get into a broken state if there is a network failure. It's on the roadmap but things aren't moving very quickly Automattic/kue#38

In the end, I experienced a bug that caused the number of redis connections to climb indefinitely OptimalBits/bull#293. I haven't had time to debug this problem.

Ultimately, the issue with kue only arises when there is a network failure (or in my case, the server rejects a connection because I have maxed out the number of available connections). I can live with this and it should be fixed once kue 1.0 is released. My only frustration there is that the current maintainer of kue is not very responsive and progress seems to have slowed to a halt.

At this time, adonis-kue is the library I would recommend using. I realize, that the naming and similarity is confusing between the two repositories. Sorry about that!

@nicklaw5
Copy link
Author

Thanks for the response @nrempel.

I guess I'll stick with kue. Hopefully v1.0 isn't far away either.

@nrempel
Copy link
Owner

nrempel commented Sep 21, 2016

Let me know if you run into any issues or if anything doesn't make sense!

@moltar
Copy link

moltar commented May 27, 2018

Any fresh thoughts on kue vs bull for a green project? It seems like bull is more mature, yet kue has adonis package. Tough choice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants