Some internal links are not rendered properly

[avaranovich]

Consider for example this

[[Script:bla_bla_bla_bla | Foo]]

should be rendered as

<a href="Script:bla_bla_bla_bla">Foo</a>

but renders as

<a href="Script:bla_bla_bla_bla"><span class="resource-prefix">Script</span>:<span class="resource-postfix">bla_bla_bla_bla</span></a>

[nricciar]

Are you using this with the github wiki? or an older version? I'm getting what one would expect...

<p><a href="script:bla_bla_bla_bla ">Foo</a></p>

It looks like something else is modifying your links if you get output like that.

[avaranovich]

Sorry, what do you mean by the "github wiki"?

[nricciar]

As in using wikicloth on github.com (project wiki pages). Github handles all the linking prior to passing the mediawiki document to WikiCloth.

[avaranovich]

I just created a test document on my filesystem. Then run ruby run_tests.rb and looking at the resulting HTML. Nothing to do with github. I just merged my fork with the master -- the same issue

[nricciar]

Looks like its your code that is adding those html tags... line 185 in your lib/wikicloth/wiki_link_handler.rb

[nricciar]

https://github.com/avaranovich/wikicloth/blob/master/lib/wikicloth/wiki_link_handler.rb#L185

[avaranovich]

Oh I see, but that code existed when I forked the project..I apply the change from your master and the issue is gone indeed.