Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need some limit for unsuccessful connections in SentinelReplication::retryCommandOnFailure #290

Closed
djagya opened this issue Nov 20, 2015 · 1 comment
Closed

Need some limit for unsuccessful connections in SentinelReplication::retryCommandOnFailure #290

djagya opened this issue Nov 20, 2015 · 1 comment
Labels
bug
Milestone
v1.1.0

Comments

@djagya
Copy link

djagya commented Nov 20, 2015

There is a problem with goto block in SentinelReplication::retryCommandOnFailure: if option autoRetry equals true this goto block will be executed infinitely (and load php and sentinel processes).
We need some limit for unsuccessful connections.
I can create a PR. For now i'm forking the lib with this and my last issue fixed
@nrk nrk added the bug label Nov 21, 2015
@nrk nrk added this to the v1.1.0 milestone Nov 21, 2015
@tom-- tom-- mentioned this issue Jan 13, 2016
Open
@nrk
Copy link
Contributor

nrk commented May 10, 2016

@djagya fixed in eb154cd, 622e6c6 and 0ec9f33. Thanks!

@nrk nrk closed this as completed May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@nrk @djagya