Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix each #448

Closed
Closed

Conversation

chihiro-adachi
Copy link

When running in the environment of php 7.2, the following warning was issued.
The each() function is deprecated. This message will be suppressed on further calls: 1x

each() function seems to be deprecated in 7.2.
http://php.net/manual/en/function.each.php

I tried to fix it, please merge if necessary.

@nrk nrk added the bug label Jul 12, 2017
nrk added a commit that referenced this pull request Jul 12, 2017
@nrk
Copy link
Contributor

nrk commented Jul 12, 2017

In the end I fixed it by simply using key() and current() (see 157f658), painless fix as there was no real need for using each() to begin with. Thank you anyway @chihiro-adachi for reporting this! By the way, the next time please do not mix commits with different scopes in a PR (that is, the fix that removed each() and the change targeting TravisCI), two separate PRs even if tiny are way better.

@nrk nrk closed this Jul 12, 2017
@chihiro-adachi
Copy link
Author

thank you 😄

@chihiro-adachi chihiro-adachi deleted the remove-each-function branch July 13, 2017 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants