Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag for stable for Silex 2 #17

Closed
SpacePossum opened this issue Sep 23, 2016 · 6 comments
Closed

Tag for stable for Silex 2 #17

SpacePossum opened this issue Sep 23, 2016 · 6 comments

Comments

@SpacePossum
Copy link
Contributor

Hi,

I was wondering if you are planning on creating a release branch/tag with a stable version for Silex 2?
Master seems stable ATM for usage with Silex 2/Pimple, but I would like to set my projects composer config on release rather than master.

@Toflar
Copy link

Toflar commented Nov 17, 2016

Same here :)

@nrk
Copy link
Owner

nrk commented Nov 17, 2016

Sorry for being so inactive on this project, I'll try to make up for it soon 😄 As for a new branch and release targeting Silex 2... yes it's going to happen, I just have a doubt if the Predis\Silex namespace should remain as is or if we could rename it as Predis\Pimple, this service provider doesn't really depend on Silex anymore after all. Any thoughts on this?

@Toflar
Copy link

Toflar commented Nov 17, 2016

No worries. I just figured the master branch is working fine for me so why not tag it :) I'm fine with changing the namespace to I'm fine withPimple` too, makes sense.

@SpacePossum
Copy link
Contributor Author

SpacePossum commented Nov 18, 2016

I've no strong opinion on the move to another namespace.
For example the Silex providers have been made independent of the Silex Application and rely on Pimple only, yet they are still in the Silex namespace (for example https://github.com/silexphp/Silex-Providers/blob/master/AssetServiceProvider.php).

@nrk
Copy link
Owner

nrk commented Dec 6, 2016

Tagged with no changes for the namespace of this provider.

@Toflar
Copy link

Toflar commented Dec 7, 2016

Thank you @nrk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants