Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial commit for sanity-plugin-nrkno-odd-utils #1

Merged
merged 7 commits into from Jan 11, 2022

Conversation

snorrees
Copy link
Contributor

@snorrees snorrees commented Jan 10, 2022

All koden i denne pakken er kopi fra nrkno-sanity med følgende endringer:

  • Mer jsdocs
  • Tester
  • I option-driven-design.md har jeg lagt til en haug med eksempler + screenshots

Testet med nrkno-sanity-lib-releaser for featurebranch:
image
(ser det mangler en newline i output her)

Hva skal reviewers gjøre

  • Les gjennom README.md.
  • Les gjennom eksemplene i bunn av option-driven-design.md.
  • Les gjennom jsdocs i koden.

Gi meg beskjed om du helst ikke vil legges på sanity-lib PR's.

@snorrees snorrees force-pushed the NRKNO-4299-odd-utils branch 2 times, most recently from ba93535 to f583a63 Compare January 10, 2022 12:01
@snorrees
Copy link
Contributor Author

Forcepush reset av versjonsummer + jeg hadde mistet githooks for å verifisere commitmelding etter git reset.

@snorrees snorrees changed the title feat: Initial commit for @nrk/sanity-plugin-nrkno-odd-utils feat: initial commit for sanity-plugin-nrkno-odd-utils Jan 10, 2022
packages/sanity-plugin-nrkno-odd-utils/README.md Outdated Show resolved Hide resolved
packages/sanity-plugin-nrkno-odd-utils/README.md Outdated Show resolved Hide resolved
packages/sanity-plugin-nrkno-odd-utils/README.md Outdated Show resolved Hide resolved
packages/sanity-plugin-nrkno-odd-utils/README.md Outdated Show resolved Hide resolved
@snorrees
Copy link
Contributor Author

Too bad at vi ikke kan kjøre autobygg for dette repo. Legger inn i PR template checkpoint om å trigge bygg.

@snorrees snorrees merged commit be208e0 into master Jan 11, 2022
@snorrees snorrees deleted the NRKNO-4299-odd-utils branch January 11, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants