chore(deps): bump sanity to v2.29.3 and adjust code after the upgrade #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artgos
requested review from
ingriddraagen,
pingrid,
rosvoll,
ajaco and
AndersCan
|
Ser jo greit ut for meg, jeg skjønner ikke 100% hvordan dette henger sammen. Men nå bruker vi v 2.29.3 her, mens vi bruker 2.29.2 i nrkno-sanity? |
|
Gjør du en test med npm link i nrkno-sanity-repo og testkjøring av bygget på jenkins? 😊 Og gir beskjed når du har gjort det? |
AndersCan
approved these changes
Apr 4, 2022
| @@ -251,6 +251,7 @@ describe('spellcheck-values', () => { | |||
| }, | |||
| }, | |||
| ], | |||
| __experimental_search: [], | |||
There was a problem hiding this comment.
Trenger vi legge til dette? https://www.sanity.io/docs/studio-search-config
Er det kanskje pga ArraySchemaType?
There was a problem hiding this comment.
Feltet er required i ObjectSchemaType fra Sanity.
ajaco
reviewed
Apr 4, 2022
| @@ -2,7 +2,7 @@ import React, { PropsWithChildren, useCallback, useContext } from 'react'; | |||
| import { Box, Button, Card, Flex, Label, Popover, Stack, Tooltip } from '@sanity/ui'; | |||
| import { SpellcheckDispatch } from './SpellcheckContext'; | |||
| import { SpellcheckProgressbar } from './SpellcheckProgressbar'; | |||
| import { TooltipProps } from '@sanity/ui/lib/src/primitives/tooltip/tooltip'; | |||
| import { TooltipProps } from '@sanity/ui/lib/dts/primitives/tooltip/tooltip'; | |||
There was a problem hiding this comment.
Kunne vi brukt
Suggested change
| import { TooltipProps } from '@sanity/ui/lib/dts/primitives/tooltip/tooltip'; | |
| import type { TooltipProps } from '@sanity/ui/lib/dts/primitives/tooltip/tooltip'; |
Her?
pingrid
approved these changes
Apr 5, 2022
artgos
force-pushed
the
NRKNO-4735-upgrade-dependencies
branch
from
6d836d6
to
03c7409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
bump sanity to v2.29.3 and adjust code after the upgrade.
Reviewers
Checklist
I have:
The branch-build must be manually triggered by the nrk.no team using nrkno-sanity-libs-releaser.
After merging, new version(s) should be published to npm by by triggering
nrkno-sanity-libs-releaser for the master branch.
These manual steps are a safeguard to prevent accidental releases and version changes.