Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade sanity to version 2.29.5 #31

Merged
merged 1 commit into from Apr 21, 2022

Conversation

artgos
Copy link
Contributor

@artgos artgos commented Apr 20, 2022

Scope

Upgrade sanity to version 2.29.5

Reviewers

Checklist

I have:

  • used conventional commit messages
  • committed with git-hooks active (ran npm install at least once locally before committing)
  • considered if this is a breaking change
  • tested the changes using npm link / yarn link
  • triggered nrkno-sanity-libs-releaser for this branch and checked the status

The branch-build must be manually triggered by the nrk.no team using nrkno-sanity-libs-releaser.

After merging, new version(s) should be published to npm by by triggering
nrkno-sanity-libs-releaser for the master branch.

These manual steps are a safeguard to prevent accidental releases and version changes.

@rosvoll
Copy link
Contributor

rosvoll commented Apr 21, 2022

Bare så jeg forstår dette riktig, nå vil vi release denne, og så kan jeg oppdatere

 "@nrk/sanity-plugin-nrkno-iframe-preview": "^1.0.7",
 "@nrk/sanity-plugin-nrkno-odd-utils": "^1.0.7",
 "@nrk/sanity-plugin-nrkno-schema-structure": "^1.0.6",
 "@nrk/sanity-plugin-nrkno-spellcheck": "^0.1.0",

i https://github.com/nrkno/nrkno-sanity/pull/414 ?

@artzag @pingrid

@pingrid
Copy link

pingrid commented Apr 21, 2022

Bare så jeg forstår dette riktig, nå vil vi release denne, og så kan jeg oppdatere

 "@nrk/sanity-plugin-nrkno-iframe-preview": "^1.0.7",
 "@nrk/sanity-plugin-nrkno-odd-utils": "^1.0.7",
 "@nrk/sanity-plugin-nrkno-schema-structure": "^1.0.6",
 "@nrk/sanity-plugin-nrkno-spellcheck": "^0.1.0",

i nrkno/nrkno-sanity#414 ?

@artzag @pingrid

Ja, det virker riktig 😊

@rosvoll
Copy link
Contributor

rosvoll commented Apr 21, 2022

.. og så finner jeg versjoner her? https://pubjenkins.felles.ds.nrk.no/job/nrkno-sanity-libs-releaser/
Hva må til nå for å release dette? merge her og trykke på i jenkins?

@artgos
Copy link
Contributor Author

artgos commented Apr 21, 2022

.. og så finner jeg versjoner her? https://pubjenkins.felles.ds.nrk.no/job/nrkno-sanity-libs-releaser/ Hva må til nå for å release dette? merge her og trykke på i jenkins?

Ja - det er det som må gjøres. Jeg er snart ferdig med tester @rosvoll

@artgos artgos merged commit 4a40bde into master Apr 21, 2022
@artgos artgos deleted the NRKNO-4735-sanity-2.29.5 branch April 21, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants