chore: Initial commit for iframe libs #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 13, 2022 23:29
NRKNO-4374
NRKNO-4374
NRKNO-4374
NRKNO-4374
NRKNO-4374
NRKNO-4374
added 3 commits
January 17, 2022 12:12
NRKNO-4374
NRKNO-4374
snorrees
requested review from
rosvoll,
pingrid,
ingriddraagen,
skjalgepalg,
ajaco,
AndersCan and
artgos
AndersCan
reviewed
Jan 17, 2022
Usikker på om jeg kommer til å bruke tid på det. Man skal ha veldig gode grunner til å endre på flyten, pga alle previewene som kjører nå. Protokollen er egentlig låst ned at this point (ie kjørt i prod uten endring i > 1år) |
NRKNO-4374
|
ty for tilbakemeldingene @AndersCan , har prøvd å rydde litt opp. Forhåpentligvis bedre nå? |
NRKNO-4374
AndersCan
approved these changes
Jan 18, 2022
|
|
||
| ``` | ||
|
|
||
| ### About the _rev field |
snorrees
commented
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope: NRKNO-4374
Flytter IFramePreview fra nrkno-sanity til nrkno-sanity-libs.
Flytter et par hooks fra nrkno-sanity til nrkno-sanity-libs (nrkno-sanity-react-utils).
Nytt lib for å integrere render-apps med IFramePreview. Før var dette bare copypasta fra docs, nå er det et lib.
La inn voltaconfig på alt, så da blir alle ting minor-bumped:
Branch: NRKNO-4374-iframe-preview
Reviewers
Les gjennom README.md filene:
Gir det mening?
Checklist
I have:
The branch-build must be manually triggered by the nrk.no team using nrkno-sanity-libs-releaser.
After merging, new version(s) should be published to npm by by triggering
nrkno-sanity-libs-releaser for the master branch.
These manual steps are a safeguard to prevent accidental releases and version changes.