Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating input name doesn't update multiviewer #59

Closed
Julusian opened this issue Sep 25, 2019 · 3 comments · Fixed by #123
Closed

Updating input name doesn't update multiviewer #59

Julusian opened this issue Sep 25, 2019 · 3 comments · Fixed by #123
Assignees
Labels
bug Something isn't working

Comments

@Julusian
Copy link
Member

Julusian commented Sep 25, 2019

I'm submitting a ...
[*] bug report

Affected
Constellation in v8.0.2
TV Studio HD in v7.5.2
2ME in v8.0.2

Unaffected
Atem Mini Pro ISO v8.6.4
Atem Mini Extreme ISO v8.6.4
(It is assumed that all of the mini range are unaffected by this)

Summary
Using setInputSettings to set the longName of a source does not update the multiviewer.
Other connected clients picks up the new device name, so the set command does work successfully. But atem client is sending an encoded image with the new name, which we are not doing.

Notes
It is the same process as a stills upload, with the following differences:
storeId = 0xffff
mode (TransferMode) = 0x0201
transferIndex = sourceId
filename = 'Label'
description = ''
hash = 0x00

The image appears to be 8bit per pixel, with some unknown encoding. Viewing in greyscale looks weird, but is recognisable.
RLE encoding can be used during the upload.
For one model, the image is 640 x 190, and contains a render for each of 4k?, 1080, and 720. But this varies based on device capabilities.

WARNING
We found that sending images with a full gradient of grey would crash the ATEM, so this needs extensive testing to ensure that our implementation is safe.

Other information
Wireshark of example atem-set-source-name-does-upload.zip
Image extracted from wireshark capture: ripped-from-wireshark.zip

@mint-dewit
Copy link
Member

The 8.2.2 updates list "Improved graphics quality in multiview display." as part of the changelog. It might have changed parts of what is described in the original issue (hopefully for the better?)

@Julusian
Copy link
Member Author

Julusian commented Jul 9, 2020

Looking at what got a firmware update, that must be referring specifically to the mini pro. So I really hope they havent changed how the images are encoded

@mint-dewit
Copy link
Member

I guess it's not unlikely it's just improvements for the Mini Pro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants