Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: REST method for disabling subdevice #649

Merged
merged 13 commits into from Jan 6, 2022
Merged

feat: REST method for disabling subdevice #649

merged 13 commits into from Jan 6, 2022

Conversation

jstarpl
Copy link
Member

@jstarpl jstarpl commented Jan 5, 2022 •
edited

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

The only way to disable a subDevice in a Peripheral Device is through the GUI

  • What is the new behavior (if this is a feature change)?

The unstable (v0) REST API now exposes a method to disable a SubDevice in a given PeripheralDevice. The PeripheralDevice's configuration manifest is inspected to make sure this is allowed.

  • Other information:

Status

  • Code documentation for the relevant parts in the code have been added/updated by the PR author
  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@jstarpl jstarpl force-pushed the feat/rest-disable-subdevice branch from 0d35f62 to c12af81 Compare January 5, 2022 16:10
@jstarpl jstarpl changed the base branch from master to release39 January 5, 2022 16:54
mint-dewit
mint-dewit requested changes Jan 6, 2022
View reviewed changes
meteor/server/api/peripheralDevice.ts Outdated Show resolved Hide resolved
meteor/server/api/rest/rest.ts Outdated Show resolved Hide resolved
packages/server-core-integration/src/lib/configManifest.ts Outdated Show resolved Hide resolved
@jstarpl jstarpl merged commit 930e27f into release39 Jan 6, 2022
@jstarpl jstarpl deleted the feat/rest-disable-subdevice branch January 6, 2022 10:17
@gundelsby gundelsby mentioned this pull request Feb 7, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mint-dewit mint-dewit mint-dewit requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jstarpl @mint-dewit