-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Route Set UI 2 #344
feat: Route Set UI 2 #344
Conversation
Adds a configuration interface to provide labels for RouteSet exclusivity groups as well as a way to enforce consistency for exclusivity group ids.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've read through the code and code-wise it looks all good!
I put some remarks on the GUI functionality as separate comments though.
Codecov Report
@@ Coverage Diff @@
## release26 #344 +/- ##
============================================
Coverage ? 67.21%
============================================
Files ? 189
Lines ? 12774
Branches ? 2843
============================================
Hits ? 8586
Misses ? 4121
Partials ? 67 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR introduces a new UI for the Route Sets.
The UI for the Route Sets consists of a couple of buttons in the sidebar in Rundown View and a modal confirmation box for enabling/disabling.
All of the controls are combined into a panel, next to the support panel, with buttons to toggle the routes on and off.
The Studio has a new map that allows specifying properties for the exclusivity groups. Currently, it's just user-facing labels.
Status