Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: let blueprint update pieceInstance in ingest data update #355

Merged
merged 15 commits into from Oct 16, 2020

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Oct 12, 2020

This PR implements the syncIngestUpdateToPartInstance update (in nrkno/sofie-blueprints-integration#80), which enables more fine-grained control over how data-updates on the currently playing (or next) Part should be handled.

Status

  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@Julusian Julusian changed the base branch from master to release26 October 12, 2020 08:35
* moved context into separate file
* add syncPlayheadInfinitesForNextPartInstance
* proper use arguments to postProcessPieces

Co-authored-by: Julian Waller <git@julusian.co.uk>
@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #355 into release26 will decrease coverage by 0.43%.
The diff coverage is 31.03%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release26     #355      +/-   ##
=============================================
- Coverage      67.19%   66.76%   -0.44%     
=============================================
  Files            189      191       +2     
  Lines          12777    12891     +114     
  Branches        2998     2869     -129     
=============================================
+ Hits            8586     8607      +21     
- Misses          4122     4216      +94     
+ Partials          69       68       -1     
Impacted Files Coverage Δ
meteor/lib/collections/PieceInstances.ts 90.90% <ø> (ø)
meteor/server/DatabaseCache.ts 86.32% <14.28%> (-4.25%) ⬇️
...ueprints/context/syncIngestUpdateToPartInstance.ts 14.54% <14.54%> (ø)
meteor/server/api/ingest/rundownInput.ts 67.05% <17.07%> (-3.17%) ⬇️
meteor/server/api/ingest/debug.ts 48.38% <36.36%> (-6.62%) ⬇️
...teor/server/api/blueprints/context/adlibActions.ts 92.07% <100.00%> (-0.19%) ⬇️
meteor/server/api/blueprints/context/context.ts 78.91% <100.00%> (ø)
meteor/server/api/blueprints/context/index.ts 100.00% <100.00%> (ø)
meteor/server/api/blueprints/context/lib.ts 100.00% <100.00%> (ø)
meteor/server/api/blueprints/postProcess.ts 76.81% <100.00%> (+7.36%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a12e973...6e2efac. Read the comment docs.

@nytamin nytamin marked this pull request as ready for review October 16, 2020 07:20
@Julusian Julusian changed the title Feat: update policies feat: let blueprint update pieceInstance in ingest data update Oct 16, 2020
@Julusian Julusian merged commit 53c0520 into release26 Oct 16, 2020
@Julusian Julusian deleted the feat/update-policies branch October 16, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants