-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: let blueprint update pieceInstance in ingest data update #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* moved context into separate file * add syncPlayheadInfinitesForNextPartInstance * proper use arguments to postProcessPieces Co-authored-by: Julian Waller <git@julusian.co.uk>
Codecov Report
@@ Coverage Diff @@
## release26 #355 +/- ##
=============================================
- Coverage 67.19% 66.76% -0.44%
=============================================
Files 189 191 +2
Lines 12777 12891 +114
Branches 2998 2869 -129
=============================================
+ Hits 8586 8607 +21
- Misses 4122 4216 +94
+ Partials 69 68 -1
Continue to review full report at Codecov.
|
…nce when updating the whole rundown
Julusian
reviewed
Oct 12, 2020
…identified (using piece.externalId) and ensuring uniqueness in case of non-unique externalId (backwards comaptible)
…ntegrity in case of crash
…artInstance' for the nextPartInstance
Julusian
changed the title
Feat: update policies
feat: let blueprint update pieceInstance in ingest data update
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the syncIngestUpdateToPartInstance update (in nrkno/sofie-blueprints-integration#80), which enables more fine-grained control over how data-updates on the currently playing (or next) Part should be handled.
Status