Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose PartEndState to the adlib actions (#518) [publish] #518

Merged
merged 5 commits into from May 28, 2021

Conversation

Julusian
Copy link
Member

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

Adlib actions are unable to access the PartEndState of the previous part. This data is owned by the blueprints, and is currently only consumed by onTimelineGenerate and future calls to getPartEndState

  • What is the new behavior (if this is a feature change)?

Adlib actions are now able to get access this PartEndState directly on any IBlueprintPartInstance.

getPartEndState has been modified to have access to the full IBlueprintPartInstance too, so that it can use the metaData or other properties.

  • Other information:

Status

  • Code documentation for the relevant parts in the code have been added/updated by the PR author
  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2021

Codecov Report

Merging #518 (9c34263) into release35 (864b186) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release35     #518      +/-   ##
=============================================
+ Coverage      67.82%   67.87%   +0.04%     
=============================================
  Files            251      251              
  Lines          15096    15146      +50     
  Branches        3534     3555      +21     
=============================================
+ Hits           10239    10280      +41     
- Misses          4689     4698       +9     
  Partials         168      168              
Impacted Files Coverage Δ
meteor/lib/collections/PartInstances.ts 90.47% <ø> (ø)
packages/blueprints-integration/src/context.ts 100.00% <ø> (ø)
...teor/server/api/blueprints/context/adlibActions.ts 91.13% <100.00%> (ø)
meteor/server/api/playout/take.ts 59.75% <100.00%> (+0.24%) ⬆️
.../server-core-integration/src/lib/configManifest.ts 100.00% <100.00%> (ø)
meteor/lib/collections/ExpectedPackages.ts 45.71% <0.00%> (-4.29%) ⬇️
meteor/server/systemStatus/systemStatus.ts 88.88% <0.00%> (+0.77%) ⬆️
meteor/lib/collections/PeripheralDevices.ts 51.16% <0.00%> (+3.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 864b186...9c34263. Read the comment docs.

@Julusian Julusian requested a review from a team May 13, 2021 10:04
Copy link
Contributor

@sparkpunkd sparkpunkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Julusian Julusian changed the title feat: expose PartEndState to the adlib actions feat: expose PartEndState to the adlib actions (#518) [publish] May 28, 2021
@Julusian Julusian merged commit 813cb03 into release35 May 28, 2021
@Julusian Julusian deleted the feat/adlib-action-persistant-storage branch May 28, 2021 14:09
@github-actions
Copy link

⚡ Published prerelease version blueprints-integration@1.35.0-nightly-release35-20210528-140916-813cb03.0 to NPM

@github-actions
Copy link

⚡ Published prerelease version server-core-integration@1.35.0-nightly-release35-20210528-140916-813cb03.0 to NPM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants