Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add baseline expectedPlayoutItems support (#520) [publish] #520

Merged
merged 7 commits into from
May 19, 2021

Conversation

Julusian
Copy link
Member

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    New feature.

  • What is the current behavior? (You can also link to an open issue here)
    No way of making Expected Playout Items (Expected Packages in the future) for items from the studio and rundown baseline.

  • What is the new behavior (if this is a feature change)?
    Changes getBaseline and getRundown return types to include Expected Playout Items (Expected Packages).
    Logic for Expected Packages not implemented yet.

  • Other information:

Status

  • Code documentation for the relevant parts in the code have been added/updated by the PR author
  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

Merging #520 (90be7be) into release35 (799874b) will increase coverage by 0.02%.
The diff coverage is 81.81%.

Impacted file tree graph

@@              Coverage Diff              @@
##           release35     #520      +/-   ##
=============================================
+ Coverage      67.82%   67.84%   +0.02%     
=============================================
  Files            251      251              
  Lines          15107    15133      +26     
  Branches        3538     3544       +6     
=============================================
+ Hits           10246    10267      +21     
- Misses          4693     4697       +4     
- Partials         168      169       +1     
Impacted Files Coverage Δ
meteor/server/api/blueprints/__tests__/lib.ts 100.00% <ø> (ø)
meteor/server/api/playout/adlib.ts 32.95% <0.00%> (-0.26%) ⬇️
meteor/server/api/ingest/cleanup.ts 63.63% <50.00%> (-3.04%) ⬇️
meteor/server/api/ingest/expectedPackages.ts 60.00% <81.81%> (+1.66%) ⬆️
meteor/server/api/ingest/expectedPlayoutItems.ts 77.41% <81.81%> (+0.14%) ⬆️
meteor/lib/collections/ExpectedPackages.ts 50.00% <100.00%> (+3.33%) ⬆️
meteor/lib/collections/ExpectedPlayoutItems.ts 100.00% <100.00%> (ø)
meteor/server/api/buckets.ts 52.41% <100.00%> (-0.33%) ⬇️
meteor/server/api/ingest/generation.ts 79.22% <100.00%> (+0.27%) ⬆️
meteor/server/api/playout/timeline.ts 68.18% <100.00%> (+0.25%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799874b...90be7be. Read the comment docs.

@Julusian Julusian changed the title feat: add baseline expectedPlayoutItems support feat: add baseline expectedPlayoutItems support (#520) [publish] May 19, 2021
@Julusian Julusian merged commit 6865b7e into release35 May 19, 2021
@Julusian Julusian deleted the test/mserk5 branch May 19, 2021 10:00
@github-actions
Copy link

⚡ Published prerelease version blueprints-integration@1.35.0-nightly-release35-20210519-100028-6865b7e.0 to NPM

@github-actions
Copy link

⚡ Published prerelease version server-core-integration@1.35.0-nightly-release35-20210519-100028-6865b7e.0 to NPM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants