Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add baseline expectedPlayoutItems support to Playout Gateway #521

Merged

Conversation

ianshade
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    A feature and minor config manifest changes related to fix: multiple VizMSE device fixes sofie-timeline-state-resolver#182

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

    • Adds baseline expectedPlayoutItems support
    • Adds config for Viz Engine REST port config
    • Fixes config property name
  • Other information:

Status

  • Code documentation for the relevant parts in the code have been added/updated by the PR author
  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@codecov-commenter
Copy link

Codecov Report

Merging #521 (efb8b40) into release35 (799874b) will increase coverage by 14.46%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           release35     #521       +/-   ##
==============================================
+ Coverage      67.82%   82.28%   +14.46%     
==============================================
  Files            251       12      -239     
  Lines          15107      858    -14249     
  Branches        3538      197     -3341     
==============================================
- Hits           10246      706     -9540     
+ Misses          4693      150     -4543     
+ Partials         168        2      -166     
Impacted Files Coverage Δ
meteor/lib/collections/MediaWorkFlows.ts
meteor/lib/collections/PartInstances.ts
meteor/server/cronjobs.ts
meteor/lib/collections/MediaWorkFlowSteps.ts
meteor/server/api/ingest/genericDevice/actions.ts
...eor/server/api/ingest/syncChangesToPartInstance.ts
meteor/server/api/integration/media-scanner.ts
meteor/server/migration/1_7_0.ts
meteor/lib/api/pubsub.ts
meteor/server/api/ingest/cache.ts
... and 229 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 799874b...efb8b40. Read the comment docs.

@nytamin nytamin added the Contribution from TV 2 Danmark Contributions sponsored by TV 2 Danmark (tv2.dk) label May 19, 2021
@nytamin nytamin requested review from a team and nytamin and removed request for a team and nytamin May 19, 2021 07:52
Copy link
Member

@Julusian Julusian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You appear to have accidentally added a tv-automation-server-core at the root of the repo.
Once you fix that I can click approve :)

@sparkpunkd sparkpunkd added the 👍 Accepted This PR is accepted by the Product Owner label Jun 4, 2021
@Julusian Julusian merged commit a2b7fa8 into nrkno:release35 Jun 4, 2021
@ianshade
Copy link
Contributor Author

ianshade commented Jun 4, 2021

This again? Sorry, VS Code doesn't indicate or warn about it when it automatically stages all changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Accepted This PR is accepted by the Product Owner Contribution from TV 2 Danmark Contributions sponsored by TV 2 Danmark (tv2.dk)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants