Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multistep graphics UI #523

Merged
merged 3 commits into from May 31, 2021
Merged

feat: multistep graphics UI #523

merged 3 commits into from May 31, 2021

Conversation

jstarpl
Copy link
Member

@jstarpl jstarpl commented May 20, 2021

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This is a new feature

  • What is the current behavior? (You can also link to an open issue here)

The GUI has no special features to display the state of multi-step graphics.

  • What is the new behavior (if this is a feature change)?

obraz

Multi-step graphics are now displayed with special "chevrons" that the graphic has multiple, user-triggerable steps and indicate the step the graphics will be on - once displayed. The hoverscrub preview of graphics should follow the assigned step as well as show the total amount of steps available.

  • Other information:

Status

  • Code documentation for the relevant parts in the code have been added/updated by the PR author
  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@jstarpl jstarpl requested a review from gundelsby May 20, 2021 06:50
@jstarpl jstarpl changed the base branch from master to release35 May 20, 2021 06:51
Copy link
Member

@gundelsby gundelsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the two comments are optional/cosmetic/subjective :)

@jstarpl jstarpl merged commit c1608f1 into release35 May 31, 2021
@jstarpl jstarpl deleted the feat/multistep-gfx-ui branch May 31, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants