Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Buckets & MOS plugins in ExternalFrames in Dashboard #195

Merged
merged 164 commits into from
May 26, 2020

Conversation

jstarpl
Copy link
Member

@jstarpl jstarpl commented Feb 14, 2020

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Adds the Bucket concept and enables ExternalFrame guests to use MOS HTML5 Plugin API

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Other information:

Status

  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

gundelsby and others added 30 commits August 30, 2019 11:54
@jstarpl
Copy link
Member Author

jstarpl commented May 7, 2020

Looks good from initial glance (I've only looked at the server-side parts).

It needs to be rebased onto release20 and functionality-tested again before merging, I think.

Rebased onto release20 and should be ready for feature-testing along with Ola's updated MOS plugin.

@codecov-io
Copy link

codecov-io commented May 14, 2020

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   66.96%   66.96%           
=======================================
  Files         151      151           
  Lines        9958     9958           
  Branches     2230     2230           
=======================================
  Hits         6668     6668           
  Misses       3256     3256           
  Partials       34       34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68157d2...68157d2. Read the comment docs.

@jstarpl
Copy link
Member Author

jstarpl commented May 14, 2020

I just realized we should wait for testing before we merge, so that we don't cause any more mess in the workflow. This should now be ready for merging.

@jstarpl jstarpl added this to the R21 milestone May 20, 2020
@jstarpl jstarpl merged commit 4103c99 into master May 26, 2020
@jstarpl jstarpl deleted the feat/adlib-mos-plugin branch May 26, 2020 09:22
@gundelsby gundelsby mentioned this pull request May 29, 2020
5 tasks
jstarpl pushed a commit that referenced this pull request Nov 29, 2022
…dDrop

Sof 1194/Make Showstyle Variants Drag and Drop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants