Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/segment header labels #478

Merged
merged 4 commits into from Mar 17, 2021
Merged

Feat/segment header labels #478

merged 4 commits into from Mar 17, 2021

Conversation

jstarpl
Copy link
Member

@jstarpl jstarpl commented Mar 15, 2021 •
edited

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This is a feature

  • What is the current behavior? (You can also link to an open issue here)

The segment header counters do not have any labels

  • What is the new behavior (if this is a feature change)?

There are now labels on the segment header to clarify the function of each of the counters.

obraz

  • Other information:

Status

  • Code documentation for the relevant parts in the code have been added/updated by the PR author
  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@jstarpl jstarpl requested a review from gundelsby March 15, 2021 14:30
gundelsby
gundelsby approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@gundelsby gundelsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@jstarpl jstarpl merged commit 7f247d5 into release32 Mar 17, 2021
@Julusian Julusian mentioned this pull request Mar 23, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gundelsby gundelsby gundelsby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jstarpl @gundelsby