Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: untimed parts #512

Merged
merged 1 commit into from Apr 30, 2021
Merged

feat: untimed parts #512

merged 1 commit into from Apr 30, 2021

Conversation

jstarpl
Copy link
Member

@jstarpl jstarpl commented Apr 29, 2021

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This is a new feature.

  • What is the current behavior? (You can also link to an open issue here)

All playable parts are counted towards show time and as-played time - unless they are "invalid" or "floated", which renders them unplayable.

  • What is the new behavior (if this is a feature change)?

A Part can be marked as "untimed" which will keep them playable, but cause them to:

  • not trigger blueprints "firstTake" callback

  • not set startedPlayback on a playlist when they are taken, the startedPlayback will be set once a not-"untimed" part is taken

  • not count towards segment time budget

  • there will be a countdown to the end of an "untimed" part (unless it's expectedDuration is 0) and the "On Air In" counter will also be affected by the duration of an "untimed" part.

  • Other information:

Status

  • Code documentation for the relevant parts in the code have been added/updated by the PR author
  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@jstarpl jstarpl requested a review from Julusian April 29, 2021 13:13
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2021

Codecov Report

Merging #512 (8c815ea) into release34 (0e68b3c) will decrease coverage by 0.87%.
The diff coverage is 100.00%.

❗ Current head 8c815ea differs from pull request most recent head 7dc4cf0. Consider uploading reports for the commit 7dc4cf0 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           release34     #512      +/-   ##
=============================================
- Coverage      66.48%   65.60%   -0.88%     
=============================================
  Files            250      240      -10     
  Lines          15064    14239     -825     
  Branches        3515     3328     -187     
=============================================
- Hits           10015     9342     -673     
+ Misses          4883     4733     -150     
+ Partials         166      164       -2     
Impacted Files Coverage Δ
meteor/lib/collections/Parts.ts 52.77% <ø> (ø)
meteor/server/api/blueprints/events.ts 76.25% <100.00%> (+0.30%) ⬆️
meteor/server/api/playout/take.ts 60.24% <100.00%> (ø)
packages/server-core-integration/src/index.ts
.../server-core-integration/src/lib/configManifest.ts
...server-core-integration/src/lib/corePeripherals.ts
...kages/server-core-integration/src/lib/ddpClient.ts
...ckages/server-core-integration/src/lib/watchDog.ts
packages/server-core-integration/src/lib/random.ts
packages/server-core-integration/src/lib/queue.ts
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e68b3c...7dc4cf0. Read the comment docs.

Copy link
Member

@Julusian Julusian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the events used for metadatabank will still be called (onRundownTimingEvent), but that could be appropriate as things did happen and the blueprints can easily filter out the parts that are untimed if it desired, so I am happy with this

Other than that it looks all good to me

@jstarpl jstarpl merged commit bd7d336 into release34 Apr 30, 2021
@jstarpl jstarpl deleted the feat/untimed-parts branch April 30, 2021 11:04
@gundelsby gundelsby mentioned this pull request Jun 30, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants