Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NextInfo panel (reopened) #578

Merged
merged 2 commits into from Oct 7, 2021

Conversation

ianshade
Copy link
Contributor

This reverts commit cc21d92, bringing back the NextInfo panel, which has been merged in #485 to a wrong branch and reverted in #516

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    A feature - new dashboard panel type.

  • What is the current behavior? (You can also link to an open issue here)
    No feature.

  • What is the new behavior (if this is a feature change)?
    This adds a new type of dashboard panel, called NextInfo panel. It displays a label consisting of:

    • name of the panel
    • name of the next Segment (the segment that the next part(Instance) of the playlist belongs to)
    • title of the next Part

    It can be configured through the RundownLayoutEditor with the following custom options:

    • Show segment name
    • Show part title
    • Hide for dynamically inserted parts - if the next part was inserted dynamically, the label will be hidden
    • Scale - font size multiplier (instead of Height)
  • Other information:
    Screenshots:
    image
    image

    Formatting (brackets around part title etc.) could be customized with CSS.

Status

  • Code documentation for the relevant parts in the code have been added/updated by the PR author
  • The functionality has been tested by the PR author
  • The functionality has been tested by NRK

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2021

Codecov Report

Merging #578 (9ced45b) into release38 (ee4ac27) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           release38     #578   +/-   ##
==========================================
  Coverage      82.44%   82.44%           
==========================================
  Files             12       12           
  Lines           1014     1014           
  Branches         198      198           
==========================================
  Hits             836      836           
  Misses           177      177           
  Partials           1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee4ac27...9ced45b. Read the comment docs.

This reverts commit cc21d92, bringing back the NextInfo panel
@ianshade ianshade force-pushed the contribute/unrevertNextInfoPanel branch from dacebd0 to 698b693 Compare September 21, 2021 08:55
@nytamin nytamin added Contribution from TV 2 Danmark Contributions sponsored by TV 2 Danmark (tv2.dk) 👍 Accepted This PR is accepted by the Product Owner labels Sep 21, 2021
Copy link
Member

@jstarpl jstarpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonably self-contained. I would suggest using React Function components going forward and using useTracker() hooks.

@jstarpl jstarpl changed the base branch from release37 to release38 September 27, 2021 10:03
@jstarpl
Copy link
Member

jstarpl commented Sep 29, 2021

@ianshade could you please look into resolving these merge conflicts?

@jstarpl jstarpl merged commit a5b583a into nrkno:release38 Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Accepted This PR is accepted by the Product Owner Contribution from TV 2 Danmark Contributions sponsored by TV 2 Danmark (tv2.dk)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants