feat: nx run in command palette and context menu #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 3d0deac. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
sandikbarr
commented
Apr 20, 2021
| @@ -49,6 +49,10 @@ export function registerCliTaskCommands( | |||
| ); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
I am not really sure of the distinction between nx-task-commands and cli-task-commands. It feels like this cli-task-commands was originally angular CLI support vs Nx CLI. I started out putting the run command support in nx-task-commands, but the flow fit in a little better here with the other CLI commands and it has all the support for getting the executor/builder definition and prompting for flags.
There was a problem hiding this comment.
yea, I noticed that as well. We'll eventually consolidate the two and just use Nx.
sandikbarr
changed the title
Cammisuli
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
nx runin the Command PalettePrompts for a project then a target and supported flags (including configuration with a dropdown of the configuration options.)