fix: enable generate from context menu setting take effect immediately #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 62a7a28. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
sandikbarr
commented
Apr 22, 2021
| @@ -47,7 +47,7 @@ | |||
| "menus": { | |||
| "explorer/context": [ | |||
| { | |||
| "when": "isGenerateFromContextMenuEnabled", | |||
| "when": "isAngularWorkspace && config.nxConsole.enableGenerateFromContextMenu || isNxWorkspace && config.nxConsole.enableGenerateFromContextMenu", | |||
There was a problem hiding this comment.
doesn't support parens with the || and &&, so the condition is a bit long
Cammisuli
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With how the "when" clause context for
isGenerateFromContextMenuEnabledis just getting set on activate, this setting isn't applying immediately like other VS Code settings do. Seems like you have to reload the window to get the setting to work.But the "when" clause can read from the
configsettings in order to toggle it on/off in your current VS Code session, so this change should fix that.