Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle absence of "properties" in schema #1208

Conversation

dmitry-stepanenko
Copy link
Contributor

@dmitry-stepanenko dmitry-stepanenko commented Dec 28, 2021

I've encountered an issue with some old repository. It contained a schematics, that didn't have properties field specified in schema.json. Schematics itself was working properly, but nx-console plugin failed to even launch. This PR adds handling of a case there's no properties field in schema.
image

@vsavkin would it be reasonable to also make properties field optional in the Schema interface in Nx repo here?

@nx-cloud
Copy link

nx-cloud bot commented Dec 28, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit f7ff450. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@Cammisuli
Copy link
Member

Thanks for the PR! Just out of curiosity, what version was that old workspace?

@dmitry-stepanenko
Copy link
Contributor Author

Thanks for the PR! Just out of curiosity, what version was that old workspace?

@Cammisuli that repo was using Angular and nx v11, but the issue is easily reproducible on latest versions

@Cammisuli Cammisuli merged commit 7d69dc7 into nrwl:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants