Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "on_hold" workflows to be detected when deriving SHAs #20

Closed
abaran30 opened this issue Apr 4, 2022 · 1 comment
Closed

Allow "on_hold" workflows to be detected when deriving SHAs #20

abaran30 opened this issue Apr 4, 2022 · 1 comment

Comments

@abaran30
Copy link
Contributor

abaran30 commented Apr 4, 2022

Describe Request:

Currently, the Nx orb will look to find the last successful workflow when deriving SHAs for Nx affected. Successful, in this case, means the CircleCI workflow has a status of success. However, this does not support main workflows that require manual approvals (e.g. deploy), as those workflows will have a status of on_hold. Because those are not considered failing workflows, we're requesting support for adding an option for the Nx orb to also check for workflows that have a status on_hold in order to support approval-based workflows.

Proposal:

#19

Supporting Documentation Links:

@meeroslav
Copy link
Collaborator

Solved by #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants