Skip to content

Commit

Permalink
feat(nx): remove prompt asking for tags and for unit and e2e test run…
Browse files Browse the repository at this point in the history
…ners
  • Loading branch information
vsavkin committed Jun 26, 2019
1 parent e720dde commit 7640598
Show file tree
Hide file tree
Showing 9 changed files with 21 additions and 57 deletions.
37 changes: 7 additions & 30 deletions packages/angular/src/schematics/application/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@
"message": "Which stylesheet format would you like to use?",
"type": "list",
"items": [
{ "value": "css", "label": "CSS" },
{
"value": "css",
"label": "CSS"
},
{
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
Expand Down Expand Up @@ -96,43 +99,17 @@
"type": "string",
"enum": ["karma", "jest", "none"],
"description": "Test runner to use for unit tests",
"default": "jest",
"x-prompt": {
"message": "Which Unit Test Runner would you like to use for the application?",
"type": "list",
"items": [
{ "value": "jest", "label": "Jest [ https://jestjs.io ]" },
{
"value": "karma",
"label": "Karma [ https://karma-runner.github.io ]"
}
]
}
"default": "jest"
},
"e2eTestRunner": {
"type": "string",
"enum": ["protractor", "cypress", "none"],
"description": "Test runner to use for end to end (e2e) tests",
"default": "cypress",
"x-prompt": {
"message": "Which E2E Test Runner would you like to use for the application?",
"type": "list",
"items": [
{
"value": "cypress",
"label": "Cypress [ https://www.cypress.io ]"
},
{
"value": "protractor",
"label": "Protractor [ https://www.protractortest.org ]"
}
]
}
"default": "cypress"
},
"tags": {
"type": "string",
"description": "Add tags to the application (used for linting)",
"x-prompt": "Which tags would you like to add to the application? (used for linting)"
"description": "Add tags to the application (used for linting)"
}
},
"required": []
Expand Down
20 changes: 7 additions & 13 deletions packages/angular/src/schematics/library/schema.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "http://json-schema.org/schema",
"id": "SchematicsNxLibrary",
"id": "SchematicsAngularLibrary",
"title": "Create a library",
"type": "object",
"properties": {
Expand Down Expand Up @@ -57,7 +57,10 @@
"message": "Which stylesheet format would you like to use?",
"type": "list",
"items": [
{ "value": "css", "label": "CSS" },
{
"value": "css",
"label": "CSS"
},
{
"value": "scss",
"label": "SASS(.scss) [ http://sass-lang.com ]"
Expand Down Expand Up @@ -89,22 +92,13 @@
},
"tags": {
"type": "string",
"description": "Add tags to the library (used for linting)",
"x-prompt": "Which tags would you like to add to the library? (used for linting)"
"description": "Add tags to the library (used for linting)"
},
"unitTestRunner": {
"type": "string",
"enum": ["karma", "jest", "none"],
"description": "Test runner to use for unit tests",
"default": "jest",
"x-prompt": {
"message": "Which Unit Test Runner would you like to use for the library?",
"type": "list",
"items": [
{ "value": "jest", "label": "Jest [https://jestjs.io/]" },
{ "value": "karma", "label": "Karma" }
]
}
"default": "jest"
}
},
"required": []
Expand Down
3 changes: 1 addition & 2 deletions packages/express/src/schematics/application/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@
},
"tags": {
"type": "string",
"description": "Add tags to the application (used for linting)",
"x-prompt": "Which tags would you like to add to the node application? (used for linting)"
"description": "Add tags to the application (used for linting)"
},
"frontendProject": {
"type": "string",
Expand Down
3 changes: 1 addition & 2 deletions packages/nest/src/schematics/application/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@
},
"tags": {
"type": "string",
"description": "Add tags to the application (used for linting)",
"x-prompt": "Which tags would you like to add to the node application? (used for linting)"
"description": "Add tags to the application (used for linting)"
},
"frontendProject": {
"type": "string",
Expand Down
3 changes: 1 addition & 2 deletions packages/node/src/schematics/application/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@
},
"tags": {
"type": "string",
"description": "Add tags to the application (used for linting)",
"x-prompt": "Which tags would you like to add to the node application? (used for linting)"
"description": "Add tags to the application (used for linting)"
},
"frontendProject": {
"type": "string",
Expand Down
3 changes: 1 addition & 2 deletions packages/react/src/schematics/application/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@
},
"tags": {
"type": "string",
"description": "Add tags to the application (used for linting)",
"x-prompt": "Which tags would you like to add to the application? (used for linting)"
"description": "Add tags to the application (used for linting)"
},
"pascalCaseFiles": {
"type": "boolean",
Expand Down
3 changes: 1 addition & 2 deletions packages/react/src/schematics/library/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,7 @@
},
"tags": {
"type": "string",
"description": "Add tags to the library (used for linting)",
"x-prompt": "Which tags would you like to add to the library? (used for linting)"
"description": "Add tags to the library (used for linting)"
},
"skipFormat": {
"description": "Skip formatting files",
Expand Down
3 changes: 1 addition & 2 deletions packages/web/src/schematics/application/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@
},
"tags": {
"type": "string",
"description": "Add tags to the application (used for linting)",
"x-prompt": "Which tags would you like to add to the application? (used for linting)"
"description": "Add tags to the application (used for linting)"
}
},
"required": []
Expand Down
3 changes: 1 addition & 2 deletions packages/workspace/src/schematics/library/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@
},
"tags": {
"type": "string",
"description": "Add tags to the library (used for linting)",
"x-prompt": "Which tags would you like to add to the library? (used for linting)"
"description": "Add tags to the library (used for linting)"
},
"skipFormat": {
"description": "Skip formatting files",
Expand Down

0 comments on commit 7640598

Please sign in to comment.