fix(angular): remove prod tsconfig for non-publishable lib (#2816)

Closes #2765
nrwl · Apr 9, 2020 · 9f0fdac · 9f0fdac
1 parent 9d20b03
commit 9f0fdac
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/packages/angular/src/schematics/library/library.spec.ts b/packages/angular/src/schematics/library/library.spec.ts
@@ -118,6 +118,18 @@ describe('lib', () => {
       ).not.toBeDefined();
     });
 
+    it('should remove tsconfib.lib.prod.json when library is not publishable', async () => {
+      const tree = await runSchematic(
+        'lib',
+        { name: 'myLib', publishable: false },
+        appTree
+      );
+
+      const libProdConfig = tree.read('libs/my-lib/tsconfig.lib.prod.json');
+
+      expect(libProdConfig).toBeFalsy();
+    });
+
     it('should update nx.json', async () => {
       const tree = await runSchematic(
         'lib',

diff --git a/packages/angular/src/schematics/library/library.ts b/packages/angular/src/schematics/library/library.ts
@@ -258,6 +258,7 @@ function updateProject(options: NormalizedSchema): Rule {
     if (!options.publishable) {
       host.delete(path.join(options.projectRoot, 'ng-package.json'));
       host.delete(path.join(options.projectRoot, 'package.json'));
+      host.delete(path.join(options.projectRoot, 'tsconfig.lib.prod.json'));
     }
 
     host.delete(path.join(options.projectRoot, 'karma.conf.js'));