feat(angular): add support for a target Builder (#4903)

Ability to support incremental builds when using target builders ISSUES CLOSED: #4896
nrwl · May 11, 2021 · a78fe65 · a78fe65
1 parent 4b73b7c
commit a78fe65
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 2 deletions.
diff --git a/docs/angular/api-angular/executors/webpack-browser.md b/docs/angular/api-angular/executors/webpack-browser.md
@@ -304,6 +304,14 @@ Type: `boolean`
 
 Enables the use of subresource integrity validation.
 
+### targetBuilder
+
+Default: `@angular-devkit/build-angular:browser`
+
+Type: `string`
+
+Override default Angular browser builder
+
 ### tsConfig
 
 Type: `string`

diff --git a/docs/node/api-angular/executors/webpack-browser.md b/docs/node/api-angular/executors/webpack-browser.md
@@ -305,6 +305,14 @@ Type: `boolean`
 
 Enables the use of subresource integrity validation.
 
+### targetBuilder
+
+Default: `@angular-devkit/build-angular:browser`
+
+Type: `string`
+
+Override default Angular browser builder
+
 ### tsConfig
 
 Type: `string`

diff --git a/docs/react/api-angular/executors/webpack-browser.md b/docs/react/api-angular/executors/webpack-browser.md
@@ -305,6 +305,14 @@ Type: `boolean`
 
 Enables the use of subresource integrity validation.
 
+### targetBuilder
+
+Default: `@angular-devkit/build-angular:browser`
+
+Type: `string`
+
+Override default Angular browser builder
+
 ### tsConfig
 
 Type: `string`

diff --git a/packages/angular/src/builders/webpack-browser/schema.json b/packages/angular/src/builders/webpack-browser/schema.json
@@ -369,9 +369,14 @@
         "type": "string"
       },
       "default": []
+    },
+    "targetBuilder": {
+      "description": "Override default Angular browser builder",
+      "type": "string",
+      "default": "@angular-devkit/build-angular:browser"
     }
   },
-  "additionalProperties": false,
+  "additionalProperties": true,
   "required": ["outputPath", "index", "main", "tsConfig"],
   "definitions": {
     "assetPattern": {

diff --git a/packages/angular/src/builders/webpack-browser/webpack-browser.impl.ts b/packages/angular/src/builders/webpack-browser/webpack-browser.impl.ts
@@ -28,8 +28,13 @@ function buildApp(
 ): Promise<BuilderRun> {
   const { buildTarget, ...delegateOptions } = options;
 
+  // delete targetBuilder from options before passing into scheduleBuilder
+  const targetBuilder =
+    (delegateOptions.targetBuilder as string) || buildTarget;
+  delete delegateOptions.targetBuilder;
+
   if (buildTarget) {
-    const target = targetFromTargetString(buildTarget);
+    const target = targetFromTargetString(targetBuilder);
     return context.scheduleTarget(target, delegateOptions, {
       target: context.target,
       logger: context.logger as any,