fix(core): handle npm package deletion and whole file changes

nrwl · Mar 10, 2020 · aa738fa · aa738fa
1 parent 235e6e4
commit aa738fa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/packages/workspace/src/core/affected-project-graph/locators/npm-packages.spec.ts b/packages/workspace/src/core/affected-project-graph/locators/npm-packages.spec.ts
@@ -87,7 +87,7 @@ describe('getTouchedNpmPackages', () => {
         }
       }
     );
-    expect(result).toEqual(['happy-nrwl']);
+    expect(result).toEqual(['proj1', 'proj2']);
   });
 
   it('should handle whole file changes', () => {
@@ -109,6 +109,6 @@ describe('getTouchedNpmPackages', () => {
         }
       }
     );
-    expect(result).toEqual(['proj1', 'proj2']);
+    expect(result).toEqual(['happy-nrwl', 'awesome-nrwl']);
   });
 });
diff --git a/packages/workspace/src/core/affected-project-graph/locators/npm-packages.ts b/packages/workspace/src/core/affected-project-graph/locators/npm-packages.ts
@@ -16,19 +16,19 @@ export const getTouchedNpmPackages: TouchedProjectLocator<
       isJsonChange(c) &&
       (c.path[0] === 'dependencies' || c.path[0] === 'devDependencies')
     ) {
-      // A package was deleted so mark all packages as touched
-      // so projects with any package dependency will be affected.
+      // A package was deleted so mark all workspace projects as touched.
       if (c.type === DiffType.Deleted) {
-        touched = Object.keys({
-          ...(packageJson.dependencies || {}),
-          ...(packageJson.devDependencies || {})
-        });
+        touched = Object.keys(workspaceJson.projects);
         break;
       } else {
         touched.push(c.path[1]);
       }
     } else if (isWholeFileChange(c)) {
-      touched = Object.keys(workspaceJson.projects);
+      // Whole file was touched, so all npm packages are touched.
+      touched = Object.keys({
+        ...(packageJson.dependencies || {}),
+        ...(packageJson.devDependencies || {})
+      });
       break;
     }
   }