fix(react): do not include package.json in libs without publishable f…

…lag (#2896)
nrwl · Apr 27, 2020 · b4fc65c · b4fc65c
1 parent 78a9fee
commit b4fc65c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/e2e/react.test.ts b/e2e/react.test.ts
@@ -28,6 +28,9 @@ forEachCli(currentCLIName => {
       );
       runCLI(`generate @nrwl/react:lib ${libName} --no-interactive`);
 
+      // Libs should not include package.json by default
+      checkFilesDoNotExist(`libs/${libName}/package.json`);
+
       const mainPath = `apps/${appName}/src/main.tsx`;
       updateFile(mainPath, `import '@proj/${libName}';\n` + readFile(mainPath));
 

diff --git a/packages/react/src/schematics/library/library.spec.ts b/packages/react/src/schematics/library/library.spec.ts
@@ -92,6 +92,7 @@ describe('lib', () => {
 
     it('should generate files', async () => {
       const tree = await runSchematic('lib', { name: 'myLib' }, appTree);
+      expect(tree.exists('libs/my-lib/package.json')).toBeFalsy();
       expect(tree.exists(`libs/my-lib/jest.config.js`)).toBeTruthy();
       expect(tree.exists('libs/my-lib/src/index.ts')).toBeTruthy();
       expect(tree.exists('libs/my-lib/src/lib/my-lib.tsx')).toBeTruthy();

diff --git a/packages/react/src/schematics/library/library.ts b/packages/react/src/schematics/library/library.ts
@@ -96,7 +96,7 @@ export default function(schema: Schema): Rule {
             pascalCaseFiles: options.pascalCaseFiles
           })
         : noop(),
-      updateLibPackageNpmScope(options),
+      options.publishable ? updateLibPackageNpmScope(options) : noop(),
       updateAppRoutes(options, context),
       formatFiles(options)
     ])(host, context);