fix(core): mark all projects as affected when npm package is deleted (#…

…2508)

packages/workspace/src/core/affected-project-graph/locators/npm-packages.spec.ts

@@ -45,8 +45,29 @@ describe('getTouchedNpmPackages', () => {
                 lhs: '0.0.1',
                 rhs: '0.0.2'
               }
-            },
-            // If it's deleted then it should not exist in project graph.
+            }
+          ]
+        }
+      ],
+      workspaceJson,
+      nxJson,
+      {
+        dependencies: {
+          'happy-nrwl': '0.0.2'
+        }
+      }
+    );
+    expect(result).toEqual(['happy-nrwl']);
+  });
+
+  it('should handle package deletion', () => {
+    const result = getTouchedNpmPackages(
+      [
+        {
+          file: 'package.json',
+          mtime: 0,
+          ext: '.json',
+          getChanges: () => [
             {
               type: DiffType.Deleted,
               path: ['dependencies', 'sad-nrwl'],
@@ -88,6 +109,6 @@ describe('getTouchedNpmPackages', () => {
         }
       }
     );
-    expect(result).toEqual(['happy-nrwl', 'awesome-nrwl']);
+    expect(result).toEqual(['proj1', 'proj2']);
   });
 });

packages/workspace/src/core/affected-project-graph/locators/npm-packages.ts

@@ -1,30 +1,37 @@
 import { isWholeFileChange, WholeFileChange } from '../../file-utils';
-import { isJsonChange, JsonChange } from '../../../utils/json-diff';
+import { DiffType, isJsonChange, JsonChange } from '../../../utils/json-diff';
 import { TouchedProjectLocator } from '../affected-project-graph-models';
 
 export const getTouchedNpmPackages: TouchedProjectLocator<
   WholeFileChange | JsonChange
 > = (touchedFiles, workspaceJson, nxJson, packageJson): string[] => {
   const packageJsonChange = touchedFiles.find(f => f.file === 'package.json');
-  const touched = [];
-  if (packageJsonChange) {
-    const changes = packageJsonChange.getChanges();
-    changes.forEach(c => {
-      if (
-        isJsonChange(c) &&
-        (c.path[0] === 'dependencies' || c.path[0] === 'devDependencies') &&
-        c.value.rhs // If rhs is blank then dep was deleted and does not exist in project graph
-      ) {
-        touched.push(c.path[1]);
-      } else if (isWholeFileChange(c)) {
-        Object.keys({
+  if (!packageJsonChange) return [];
+
+  let touched = [];
+  const changes = packageJsonChange.getChanges();
+
+  for (const c of changes) {
+    if (
+      isJsonChange(c) &&
+      (c.path[0] === 'dependencies' || c.path[0] === 'devDependencies')
+    ) {
+      // A package was deleted so mark all packages as touched
+      // so projects with any package dependency will be affected.
+      if (c.type === DiffType.Deleted) {
+        touched = Object.keys({
           ...(packageJson.dependencies || {}),
           ...(packageJson.devDependencies || {})
-        }).forEach(p => {
-          touched.push(p);
         });
+        break;
+      } else {
+        touched.push(c.path[1]);
       }
-    });
+    } else if (isWholeFileChange(c)) {
+      touched = Object.keys(workspaceJson.projects);
+      break;
+    }
   }
+
   return touched;
 };