fix(node): use webpack compilation hooks to emit package.json #10229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
skrtheboss
force-pushed
the
fix/use-compilation-hooks-for-emitting-package-json
branch
2 times, most recently
from
92cb8ff
to
26922df
Compare
skrtheboss
force-pushed
the
fix/use-compilation-hooks-for-emitting-package-json
branch
from
26922df
to
e17f7c8
Compare
skrtheboss
force-pushed
the
fix/use-compilation-hooks-for-emitting-package-json
branch
2 times, most recently
from
0ddb3e3
to
6f569a1
Compare
|
Thanks for the PR, we'll review it to see if this is the right approach. |
|
@skrtheboss thank you for the PR. I tested this locally and it looks good. Can you rebase with latest and resolve the merge conflict? |
Use the webpack plugin system to create the package.json, this allows for developers to use plugins like CleanWebpackPlugin which clears the dist before the compilation starts. If this plugin is used in combination with the old method of generating the package.json, then it is deleted on compilation start.
skrtheboss
force-pushed
the
fix/use-compilation-hooks-for-emitting-package-json
branch
from
6f569a1
to
de59f0d
Compare
|
Hi @nartc, I have solved the merge conflict. Let me know if you need me to do something else. |
skrtheboss
deleted the
fix/use-compilation-hooks-for-emitting-package-json
branch
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the webpack plugin system to create the package.json, this allows for developers to use plugins like
CleanWebpackPlugin which clears the dist before the compilation starts. If this plugin is used in
combination with the old method of generating the package.json, then it is deleted on compilation start.