Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failes after upgrade to v14.2.1 #10626

Closed
hamzou247 opened this issue Jun 7, 2022 · 5 comments · Fixed by #10635
Closed

Build failes after upgrade to v14.2.1 #10626

hamzou247 opened this issue Jun 7, 2022 · 5 comments · Fixed by #10635
Assignees
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug

Comments

@hamzou247
Copy link

Current Behavior

Library build fails after migration from v13 to v14.

Understood that package.json will no longer be supported in newer packagr builds.

Expected Behavior

Build passes

Steps to Reproduce

  1. Migrate to v14
  2. build library

Failure Logs

$ nx build shared-shared

nx run shared-shared:build:production

Building Angular Package
Cannot discover package sources at C:\projects\safe-sante\safesante\libs\shared\shared\ng-package.json as 'package.json' was not found.

Environment

  • Windows 11
  • VSCode
  • Angular
  • NX

NX Report complete - copy this into the issue template

Node : 14.17.3
OS : win32 x64
npm : 6.14.13

nx : 14.2.1
@nrwl/angular : 14.2.1
@nrwl/cypress : 14.2.1
@nrwl/detox : Not Found
@nrwl/devkit : 14.2.1
@nrwl/eslint-plugin-nx : 14.2.1
@nrwl/express : Not Found
@nrwl/jest : 14.2.1
@nrwl/js : 14.2.1
@nrwl/linter : 14.2.1
@nrwl/nest : Not Found
@nrwl/next : Not Found
@nrwl/node : Not Found
@nrwl/nx-cloud : 14.0.5
@nrwl/nx-plugin : Not Found
@nrwl/react : Not Found
@nrwl/react-native : Not Found
@nrwl/schematics : Not Found
@nrwl/storybook : 14.2.1
@nrwl/web : Not Found
@nrwl/workspace : 14.2.1
typescript : 4.7.3

Community plugins:
@ng-bootstrap/ng-bootstrap: 11.0.1
@nguniversal/builders: 13.1.0
@nguniversal/express-engine: 13.1.0
ng2-charts: 3.0.9
ngx-store: 3.1.1
@compodoc/compodoc: 1.1.19
@storybook/angular: 6.5.5
@trumbitta/nx-plugin-unused-deps: 1.10.0

@fatihdogmus
Copy link

same problem. when I revert the package.json files deletion, the build passes.

@WolfSoko
Copy link

WolfSoko commented Jun 8, 2022

Same problem

@leosvelperez
Copy link
Member

Thanks for reporting this!

Could you please provide a repo where this issue can be reproduced? I couldn't reproduce it, but I'm wondering if it's an issue that only happens on Windows 🤔

@leosvelperez leosvelperez added the scope: angular Issues related to Angular support in Nx label Jun 8, 2022
@leosvelperez leosvelperez self-assigned this Jun 8, 2022
@leosvelperez
Copy link
Member

I was able to confirm this is an issue on Windows machines. A fix is on the way. For anyone that has already had the issue, please revert the deletion of the package.json files located at the library root. If you have secondary entry points where a package.json file was deleted and a new ng-package.json file was created, please don't revert that change as it's intended.

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: angular Issues related to Angular support in Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants