New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular): replace mfe references with mf #10957
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/angular/src/migrations/update-14-0-0/rename-mf-config.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
align-mf-naming
branch
2 times, most recently
from
July 1, 2022 10:35
6ef8684
to
9a96587
Compare
leosvelperez
reviewed
Jul 1, 2022
packages/angular/src/migrations/update-13-3-0/update-mfe-webpack-config.spec.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/migrations/update-13-3-0/update-mfe-webpack-config.spec.ts
Outdated
Show resolved
Hide resolved
leosvelperez
approved these changes
Jul 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to focus on pushing
module-federation
as the terminology, therefore this PR will remove any exposed references to MFE.