Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): collect secondary folders correctly for tailwind #11747 #11805

Merged
merged 1 commit into from Sep 1, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Aug 31, 2022

Current Behavior

For libraries, our glob creation function only checks under src for classes for tailwind.

Expected Behavior

We should also check alternate folders for secondary entry points

Related Issue(s)

Fixes #11747

@Coly010 Coly010 self-assigned this Aug 31, 2022
@vercel
Copy link

vercel bot commented Aug 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Sep 1, 2022 at 9:42AM (UTC)

@montella1507
Copy link

montella1507 commented Aug 31, 2022

Probably related to problem with Storybooks too (not found under secondary-entry-point libraries)

#11446 (comment)

EDIT: ah, you have already realized. NIce! You are my hero :-)

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Coly010
Copy link
Contributor Author

Coly010 commented Sep 1, 2022

LGTM! 🎉

Adding the gitignore feature :)

@Coly010 Coly010 enabled auto-merge (squash) September 1, 2022 10:01
@Coly010 Coly010 merged commit 62d2d82 into nrwl:master Sep 1, 2022
@Coly010 Coly010 deleted the fix-tw-lse branch September 1, 2022 10:05
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants