Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): add check if scripts exist or fallback to empty array #12110

Merged
merged 1 commit into from Sep 23, 2022

Conversation

miles170
Copy link
Contributor

Current Behavior

When I use @nrwl/node:webpack as executor, the build fails because of undefined buildOptions.scripts.

Expected Behavior

The build can be built using the @nrwl/node:webpack executor.

@vercel
Copy link

vercel bot commented Sep 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Sep 20, 2022 at 4:27AM (UTC)

@nartc nartc merged commit 94a2b0b into nrwl:master Sep 23, 2022
@miles170 miles170 deleted the webpack branch September 23, 2022 10:13
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants